Properly configure Coroutines cmake module#34
Open
karzhenkov wants to merge 3 commits intoandreasbuhr:mainfrom
Open
Properly configure Coroutines cmake module#34karzhenkov wants to merge 3 commits intoandreasbuhr:mainfrom
karzhenkov wants to merge 3 commits intoandreasbuhr:mainfrom
Conversation
Owner
|
Hi @karzhenkov , |
arthurzam
added a commit
to arthurzam/cppcoro
that referenced
this pull request
Oct 25, 2021
|
Any update of integrating this into the main branch? I stumbled upon the same problem and it would be nice to be able to just clone the main branch from my build system. Thank you guys for your efforts! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are some problems when using
cppcorofrom an external project:The first commit adds tests that attempt to build an executable using
cppcoro:app_build_with_cppcoro_install_dirapp_build_with_cppcoro_build_treecppcoroand configure the application build tree.Following commits make the tests successful.
This PR should probably go to
add_cmake_support, but that branch looks somewhat outdated.